Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real masses are copied in copied reactions #2304

Open
HueppeH opened this issue Jan 22, 2025 · 0 comments
Open

Real masses are copied in copied reactions #2304

HueppeH opened this issue Jan 22, 2025 · 0 comments
Labels

Comments

@HueppeH
Copy link

HueppeH commented Jan 22, 2025

  • I am an ELNer

Expected Behavior

Please describe the behavior you are expecting

If I copy a reaction I expect that the theoretical masses are copied as I have the same theoretical plan as last time on repeating the experiment but I expect the real masses to be deleted in the copied reaction as the real masses in the repetition experiment do not necessarily have to be the same. (Additionally, lazy users probably can keep the real masses from last time without checking if they really used the exact same amount.)
(Yields are not copied when copying a reaction. For the real amounts of starting material it should be the same.)

Current Behavior

What is the current behavior?

Currently the real masses are also copied when copying the reaction.

Failure Information

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. step 1 create new reaction with theoretical and real masses.
    Theoretical:
    Image
    Real:
    Image

  2. step 2 copy reaction

  3. you get it... Copied reaction shows the "old" real masses from the parent reaction (marked yellow).
    Additionally the yields from the parent reaction are shown in the copied reaction in the reaction equation picture until the copied reaction is saved. This is a bug, too.

before saving:
Image
after saving:
Image

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • OS: Windows 10
  • Opera Browser
  • ELN version, or branch, or commit: Version: v1.10.5
    Base revision: f2f95e7
    Current revision: f2f95e7

Note

If the behavior is intended that the real masses are copied, too, I would suggest a pop-up window where the user can decide if the real values for the starting material should be kept or not: e.g. (Do you want to copy the real starting material amounts, too? [yes] [no] ). At least this enhances the awareness for checking the correctness of this values.

@HueppeH HueppeH added the bug label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant