Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When using a different language (non-English) in the system, Keybinding does not work #2340

Open
Shyryp opened this issue Jan 24, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Shyryp
Copy link

Shyryp commented Jan 24, 2025

Frontend Version

ComfyUI_frontend v1.8.5

Expected Behavior

When using different language (not English) in the system, any key combinations set in the settings should work. It should not be that CTRL+S does not work when using a different language set in the system.
I expect that the CTRL+S I set up will always work, in any locales and system languages ​​(in any keyboard layout).

Actual Behavior

When using a different language (non-English) in the system, Keybinding does not work.
More precisely, ONLY those keybindings that are set in the current language start to work.

Steps to Reproduce

  1. Switch the system keyboard layout to Russian.
  2. Try using the hotkey CTRL+S, which was set in the Keybindings settings.

What browsers do you use to access the UI ?

Google Chrome

Other

I assume this is an intentional change?

However, I really wish this behavior could be disabled, as I often switch between two languages ​​in the system, which is why keybindings simply do not work if they are set in another language.

Also, if this innovation is left as is, it would be very useful to add in this case the ability to add multiple hotkeys for one action.
For example, if I used the "Save Workflow" function, I would set two hotkeys for different locales (English and Russian):
CTRL+S; CTRL+Ы

┆Issue is synchronized with this Notion page by Unito

@Shyryp Shyryp added the Potential Bug Untriaged bug label Jan 24, 2025
@Shyryp Shyryp changed the title [Bug]: When using a different locale (non-English) and with a different language (non-English) enabled in the system, Keybinding does not work [Bug]: When using a different language (non-English) in the system, Keybinding does not work Jan 24, 2025
@huchenlei huchenlei added bug Something isn't working and removed Potential Bug Untriaged bug labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants