Changes in forward sync and rate limit constants #8982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
changed the title
StefanBratanov
changed the title
StefanBratanov
force-pushed
the
forward_sync_constants
branch
from
b3d208e to
d63e446
Compare
StefanBratanov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
DEFAULT_FORWARD_SYNC_BATCH_SIZEto 25 instead of 50 to cater for the time for validating blobs, state transition, etc-Xp2p-sync-rate-limitin favour of-Xp2p-sync-blocks-rate-limitand-Xp2p-sync-blob-sidecars-rate-limit--Xpeer-rate-limitin favour of--Xpeer-blocks-rate-limitand--Xpeer-blob-sidecars-rate-limitDEFAULT_FORWARD_SYNC_MAX_BLOB_SIDECARS_PER_MINUTEto 2000 (outgoing rate limit). The previous500 * maxBlobsPerBlockseems too large.DEFAULT_PEER_BLOB_SIDECARS_RATE_LIMITto 2000 (incoming rate limit). The previous500 * maxBlobsPerBlockseems too large.DEFAULT_PEER_REQUEST_LIMITto 100 from 50, because it hasn't been changed after Deneb. It makes sense to double to account for blobs requests when syncing.2000 Blobs (TBD) is ~250 MB per minute per peer
Fixed Issue(s)
fixes #8871
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog