Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you really need ACCESS_FINE_LOCATION permission? #55

Open
sonew-c opened this issue May 12, 2020 · 3 comments
Open

Do you really need ACCESS_FINE_LOCATION permission? #55

sonew-c opened this issue May 12, 2020 · 3 comments

Comments

@sonew-c
Copy link

sonew-c commented May 12, 2020

dp3t-app-android/app/src/main/AndroidManifest.xml
Line 18:

Are you sure you want to have this? It seems to defeat the purpose of the app itself.

BTW, good project

@goebelUB
Copy link

https://developer.android.com/guide/topics/connectivity/bluetooth#Permissions

@aemxn
Copy link

aemxn commented Jun 9, 2020

According to Switzerland's client manifest file, it doesn't include this line.

https://github.com/DP-3T/dp3t-app-android-ch/blob/master/app/src/main/AndroidManifest.xml#L14

Can someone clarify this?

EDIT: I think this issue have also discussed about it SwissCovid/swisscovid-app-android#61

@Filius-Patris
Copy link

(I'm not 100% sure on this. Correct me if I'm wrong)

AFAIK the SwissCovid app uses the ExposureNotification framework provided by Google. As this call goes through the Google Play libraries and not the OS, permissions required are specified by the library.
On the thread you mentioned, they cite the specifications, which clearly state that you do not have to have the ACCESS_FINE_LOCATION permission. (If I understood correctly, you may even not have it.)

I think this repo does not use the Google backend and makes the call through the OS. Thus it needs the ACCESS_FINE_LOCATION permission to scan for BLE beacons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants