From 91c884c08edd9273829b3711aeb325cd5ea99682 Mon Sep 17 00:00:00 2001 From: Ivo Anjo Date: Mon, 21 Aug 2023 15:26:13 +0100 Subject: [PATCH] Remove broken "Test unstable" GitHub action **What does this PR do?**: The "Test unstable" GitHub Action runs the dd-trace-rb CI with ruby-head and jruby-head. Because ruby-head and jruby-head aren't always rock solid, we've marked these tests with "continue-on-error: true" which in practice means you need to actually open them to know if they failed, because they get always marked as succeeded. Today, while looking into our CI config, I noticed these tests have been broken for what looks like *months* (due to some refactoring in our gemspec): ``` [!] There was an error parsing `Gemfile`: [!] There was an error while loading `ddtrace.gemspec`: syntax error, unexpected ']', expecting `end' or dummy end - ...ERSION::MAXIMUM_RUBY_VERSION}"] ... ^ . Bundler cannot continue. # from /home/runner/work/dd-trace-rb/dd-trace-rb/ddtrace.gemspec:10 # ------------------------------------------- # spec.version = DDTrace::VERSION::STRING > "< #{DDTrace::VERSION::MAXIMUM_RUBY_VERSION}"] # spec.required_rubygems_version = '>= 2.0.0' # ------------------------------------------- . Bundler cannot continue. # from /home/runner/work/dd-trace-rb/dd-trace-rb/Gemfile:3 # ------------------------------------------- # > gemspec # # ------------------------------------------- Error: The process '/home/runner/.rubies/ruby-head/bin/bundle' failed with exit code 14 ``` (https://github.com/DataDog/dd-trace-rb/actions/runs/5890935813/job/15977021676) Nobody seems to notice when they fail, and thus it really looks like we're not getting any value at all. Thus, I decided to open a PR to remove them for now. **Motivation**: As our CI gets more complex, we get little value from things that need to be checked manually -- nowadays we have hundreds of validations. **Additional Notes**: N/A **How to test the change?**: Validate that CI is still green, and this action no longer runs. --- .github/workflows/test-head.yaml | 41 -------------------------------- 1 file changed, 41 deletions(-) delete mode 100644 .github/workflows/test-head.yaml diff --git a/.github/workflows/test-head.yaml b/.github/workflows/test-head.yaml deleted file mode 100644 index ad2830d3fa7..00000000000 --- a/.github/workflows/test-head.yaml +++ /dev/null @@ -1,41 +0,0 @@ -name: Test unstable -on: [push] -jobs: - test-head: - strategy: - fail-fast: false - matrix: - ruby: [head, jruby-head] - runs-on: ubuntu-latest - env: - SKIP_SIMPLECOV: 1 - JRUBY_OPTS: --dev - DD_INSTRUMENTATION_TELEMETRY_ENABLED: false - DD_REMOTE_CONFIGURATION_ENABLED: false - steps: - - uses: actions/checkout@v3 - # bundler appears to match both prerelease and release rubies when we - # want the former only. relax the constraint to allow any version for - # head rubies - - run: sed -i~ -e '/spec\.required_ruby_version/d' ddtrace.gemspec - - uses: ruby/setup-ruby@31a7f6d628878b80bc63375a93ae079ec50a1601 # v1.143.0 - with: - ruby-version: ${{ matrix.ruby }} - bundler-cache: true # runs 'bundle install' and caches installed gems automatically - continue-on-error: true - - run: bundle exec rake spec:main - continue-on-error: true - - run: bundle exec rake spec:contrib - continue-on-error: true - - run: bundle exec rake spec:opentracer - continue-on-error: true - # A few contrib jobs that `ddtrace` already includes their gem in the global Gemfile. - # We technically don't need appraisal to run them, thus are easy candidates for early testing. - - run: bundle exec rake spec:rake - continue-on-error: true - - run: bundle exec rake spec:rspec - continue-on-error: true - - run: bundle exec rake spec:concurrent_ruby - continue-on-error: true - - run: bundle exec rake spec:http - continue-on-error: true