Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog-opeartor No mechanism exists to enable OTeL Collector for operator versions ~v1.8.0<=x<=v1.11.1 #1657

Open
wspurgin opened this issue Jan 3, 2025 · 0 comments

Comments

@wspurgin
Copy link

wspurgin commented Jan 3, 2025

Problem

From DataDog/datadog-operator@4bc766f (I believe this is v1.8.0) to the most recent release of this writing (v1.11.1) there is no mechanism to add the command line arg otelEnabled to the deployment created in this chart to enable OTeL support.

e.g., for the latest release of this chart (2.5.0) https://github.com/DataDog/helm-charts/blob/datadog-operator-2.5.0/charts/datadog-operator/templates/deployment.yaml#L104-L137

The arguments passed are tightly controlled by what is present in Values.

Proposal

Expose through Values an additionalCommandArgs that allow users to specify additional flags/args at their own risk. For users of the operator v1.8-v1.11.1 this will allow them to enable OTeL (and any other features currently not configurable through the operator config or the helm chart).

Considerations

Currently in main (but unreleased) the operator adds OTeL as a "default" feature DataDog/datadog-operator#1559, and it removes this arg as a "non-breaking" change. Given that it wasn't exposed, that's probably correct, but the additionalCommandArgs (or whatever it might be called) should likely recommend caution (and perhaps even pinning operator versions) if it's leveraged.

@wspurgin wspurgin changed the title datadog-opeartor No mechanism exists to enable OTeL for operator versions ~v1.8.0<=x<=v1.11.1 datadog-opeartor No mechanism exists to enable OTeL Collector for operator versions ~v1.8.0<=x<=v1.11.1 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant