From 6c7ccdec8db626c4bcbd470cb7ede6b76b329659 Mon Sep 17 00:00:00 2001
From: takahirom <takam.dev@gmail.com>
Date: Sun, 7 Jul 2024 13:16:28 +0900
Subject: [PATCH] Use it instead of 'check' to follow the naming convention

---
 .../RobolectricDescribeSpecParameterBuilder.kt   | 16 ++++++++--------
 .../sessions/TimetableItemDetailScreenTest.kt    | 16 ++++++++--------
 .../confsched/sessions/TimetableScreenTest.kt    | 10 +++++-----
 3 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/core/testing/src/main/java/io/github/droidkaigi/confsched/testing/RobolectricDescribeSpecParameterBuilder.kt b/core/testing/src/main/java/io/github/droidkaigi/confsched/testing/RobolectricDescribeSpecParameterBuilder.kt
index ce45cc71f..36152a414 100644
--- a/core/testing/src/main/java/io/github/droidkaigi/confsched/testing/RobolectricDescribeSpecParameterBuilder.kt
+++ b/core/testing/src/main/java/io/github/droidkaigi/confsched/testing/RobolectricDescribeSpecParameterBuilder.kt
@@ -12,7 +12,7 @@ suspend fun <T> DescribedTestCase<T>.execute(robot: T) {
         println("Executing step: $index ($description)")
         when (step) {
             is TestNode.Run -> step.action(robot)
-            is TestNode.Check -> {
+            is TestNode.It -> {
                 if (step.description == targetCheckDescription) {
                     step.action(robot)
                 }
@@ -27,7 +27,7 @@ suspend fun <T> DescribedTestCase<T>.execute(robot: T) {
 sealed class TestNode<T> {
     data class Describe<T>(val description: String, val children: List<TestNode<T>>) : TestNode<T>()
     data class Run<T>(val action: suspend T.() -> Unit) : TestNode<T>()
-    data class Check<T>(val description: String, val action: suspend T.() -> Unit) : TestNode<T>()
+    data class It<T>(val description: String, val action: suspend T.() -> Unit) : TestNode<T>()
 }
 
 data class DescribedTestCase<T>(
@@ -46,7 +46,7 @@ data class AncestryNode<T>(
 data class CheckNode<T>(
     val description: String,
     val fullDescription: String,
-    val node: TestNode.Check<T>,
+    val node: TestNode.It<T>,
     val ancestry: List<AncestryNode<T>>,
 )
 
@@ -63,8 +63,8 @@ class TestCaseTreeBuilder<T> {
         children.add(TestNode.Run { action() })
     }
 
-    fun check(description: String, action: suspend T.() -> Unit) {
-        children.add(TestNode.Check(description) { action() })
+    fun it(description: String, action: suspend T.() -> Unit) {
+        children.add(TestNode.It(description) { action() })
     }
 
     fun build(): TestNode.Describe<T> = TestNode.Describe("", children)
@@ -93,9 +93,9 @@ private fun <T> collectCheckNodes(root: TestNode.Describe<T>): List<CheckNode<T>
                 }
             }
 
-            is TestNode.Check -> {
+            is TestNode.It -> {
                 val fullDescription = if (parentDescription.isNotBlank()) {
-                    "$parentDescription - ${node.description}"
+                    "$parentDescription - it ${node.description}"
                 } else {
                     node.description
                 }
@@ -136,7 +136,7 @@ private fun <T> createTestCase(checkNode: CheckNode<T>): DescribedTestCase<T> {
                 steps.add(node)
             }
 
-            is TestNode.Check -> {
+            is TestNode.It -> {
                 if (node == checkNode.node) {
                     steps.add(node)
                 }
diff --git a/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt b/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt
index adb25c285..37dea477e 100644
--- a/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt
+++ b/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreenTest.kt
@@ -54,18 +54,18 @@ class TimetableItemDetailScreenTest(private val testCase: DescribedTestCase<Time
                         run {
                             setupScreenContent()
                         }
-                        check("should show session detail title") {
+                        it("should show session detail title") {
                             // FIXME: Add check for session detail title
                             captureScreenWithChecks()
                         }
-                        check("check accessibility") {
+                        it("check accessibility") {
                             checkAccessibilityCapture()
                         }
                         describe("click bookmark button") {
                             run {
                                 clickBookmarkButton()
                             }
-                            check("should show bookmarked session") {
+                            it("should show bookmarked session") {
                                 // FIXME: Add check for bookmarked session
                                 captureScreenWithChecks()
                             }
@@ -73,7 +73,7 @@ class TimetableItemDetailScreenTest(private val testCase: DescribedTestCase<Time
                                 run {
                                     clickBookmarkButton()
                                 }
-                                check("should show unbookmarked session") {
+                                it("should show unbookmarked session") {
                                     // FIXME: Add check for unbookmarked session
                                     captureScreenWithChecks()
                                 }
@@ -83,7 +83,7 @@ class TimetableItemDetailScreenTest(private val testCase: DescribedTestCase<Time
                             run {
                                 scroll()
                             }
-                            check("should show scrolled session detail") {
+                            it("should show scrolled session detail") {
                                 // FIXME: Add check for scrolled session detail
                                 captureScreenWithChecks()
                             }
@@ -94,7 +94,7 @@ class TimetableItemDetailScreenTest(private val testCase: DescribedTestCase<Time
                             setFontScale(0.5f)
                             setupScreenContent()
                         }
-                        check("should show session detail with small font scale") {
+                        it("should show session detail with small font scale") {
                             captureScreenWithChecks()
                         }
                     }
@@ -103,7 +103,7 @@ class TimetableItemDetailScreenTest(private val testCase: DescribedTestCase<Time
                             setFontScale(1.5f)
                             setupScreenContent()
                         }
-                        check("should show session detail with large font scale") {
+                        it("should show session detail with large font scale") {
                             captureScreenWithChecks()
                         }
                     }
@@ -112,7 +112,7 @@ class TimetableItemDetailScreenTest(private val testCase: DescribedTestCase<Time
                             setFontScale(2.0f)
                             setupScreenContent()
                         }
-                        check("should show session detail with huge font scale") {
+                        it("should show session detail with huge font scale") {
                             captureScreenWithChecks()
                         }
                     }
diff --git a/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableScreenTest.kt b/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableScreenTest.kt
index d87af33ae..4b30e220a 100644
--- a/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableScreenTest.kt
+++ b/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableScreenTest.kt
@@ -42,7 +42,7 @@ class TimetableScreenTest(private val testCase: DescribedTestCase<TimetableScree
                         setupTimetableServer(ServerStatus.Operational)
                         setupTimetableScreenContent()
                     }
-                    check("should show timetable items") {
+                    it("should show timetable items") {
                         captureScreenWithChecks(checks = {
                             checkTimetableItemsDisplayed()
                         })
@@ -51,7 +51,7 @@ class TimetableScreenTest(private val testCase: DescribedTestCase<TimetableScree
                         run {
                             clickFirstSessionBookmark()
                         }
-                        check("should show bookmarked session") {
+                        it("should show bookmarked session") {
                             // FIXME: Add check for bookmarked session
                             captureScreenWithChecks()
                         }
@@ -60,7 +60,7 @@ class TimetableScreenTest(private val testCase: DescribedTestCase<TimetableScree
                         run {
                             clickFirstSession()
                         }
-                        check("should show session detail") {
+                        it("should show session detail") {
                             checkClickedItemsExists()
                         }
                     }
@@ -68,7 +68,7 @@ class TimetableScreenTest(private val testCase: DescribedTestCase<TimetableScree
                         run {
                             clickTimetableUiTypeChangeButton()
                         }
-                        check("should change timetable ui type") {
+                        it("should change timetable ui type") {
                             // FIXME: Add check for timetable ui type change
                             captureScreenWithChecks()
                         }
@@ -79,7 +79,7 @@ class TimetableScreenTest(private val testCase: DescribedTestCase<TimetableScree
                         setupTimetableServer(ServerStatus.Error)
                         setupTimetableScreenContent()
                     }
-                    check("should show error message") {
+                    it("should show error message") {
                         // FIXME: Add check for error message
                         captureScreenWithChecks()
                     }