-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big PR #43
Closed
Closed
Big PR #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SocketConnection that finished connection.
added function in ServerSocket and SocketConnection
enum cannot be a global in c++98. That sucks, that also means I will need to refactor some things
This was the best fix I could think of that wouldn't change the whole implementatio
…inary for the project
modified: configs/default modified: includes/cgi/CGIContext.hpp modified: includes/utils/Logger.hpp modified: srcs/http/HTTPHandler.cpp modified: srcs/http/HTTPResponse.cpp modified: webserv
This was
linked to
issues
Apr 6, 2023
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to change things, the logic is still the same and tried to only add things instead of modifying what was already done