Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Adapt CDAT Migration regression testing scripts for general purpose use #894

Open
tomvothecoder opened this issue Nov 11, 2024 · 2 comments · May be fixed by #903
Open

[Feature]: Adapt CDAT Migration regression testing scripts for general purpose use #894

tomvothecoder opened this issue Nov 11, 2024 · 2 comments · May be fixed by #903
Assignees
Labels
DevOps CI/CD, configuration, etc. enhancement

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Nov 11, 2024

Is your feature request related to a problem?

The current integration test uses image checking to compare pixels. These tests often break due to very subtle differences that are introduced externally through different versions of packages, especially matplotlib.

Describe the solution you'd like

The CDAT migration regression testing script adapts the run__...py script to run the sets. We then manually update a regression testing notebook to compare the results against the latest main (right now CDAT-based).

Describe alternatives you've considered

No response

Additional context

No response

@tomvothecoder tomvothecoder added enhancement DevOps CI/CD, configuration, etc. labels Nov 11, 2024
@chengzhuzhang
Copy link
Contributor

Thank you for creating this issue. I think we can use v3 simulation data for the complete run. There is a bash file I created for the 2024 tutorial which include the required input data for all sets. https://github.com/E3SM-Project/e3sm_diags/blob/14612912b66fb71ac0e82504034ded2e8e2aba71/examples/tutorials2024/e3sm_diags_extended.bash

@tomvothecoder tomvothecoder self-assigned this Nov 12, 2024
@chengzhuzhang
Copy link
Contributor

Actually this run script covers complete sets: https://portal.nersc.gov/cfs/e3sm/chengzhu/tutorial2024/e3sm_diags_extended_int/prov/e3sm.py (it include two more sets: zonal_mean_2d_stratopshere and tc_analysis compare to the one provided in #894 (comment))

@tomvothecoder tomvothecoder changed the title [Feature]: Adapt CDAT Migration regression testing scripts as integration tests to replace image checker [Feature]: Adapt CDAT Migration regression testing scripts for general purpose use Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps CI/CD, configuration, etc. enhancement
Projects
None yet
2 participants