Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking if a variable is a record variable when using PnetCDF #594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

checking if a variable is a record variable when using PnetCDF #594

wants to merge 1 commit into from

Conversation

wkliao
Copy link
Member

@wkliao wkliao commented Jul 3, 2024 •
edited by jayeshkrishna
Loading

Since CDF-1,2,5 formats supported by PnetCDF only allow
a single (first) unlimited dimension, optimizing the check for
a record variable by limiting the dimensions checked to the
first dimension.

Fixes #519

@jayeshkrishna
Copy link
Contributor

@dqwu : Please update the PR description and the commit message to reflect the changes.

Thanks @wkliao for the patch.

@jayeshkrishna
Copy link
Contributor

@dqwu : I just updated the PR desc. Also update the commit message accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayeshkrishna jayeshkrishna Awaiting requested review from jayeshkrishna

@dqwu dqwu Awaiting requested review from dqwu

Assignees

@dqwu dqwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checking if a variable is a record variable when using PnetCDF option
3 participants
@wkliao @jayeshkrishna @dqwu