-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining issues in the ACI code #2858
Labels
EAGLES
Work related to the EAGLES aerosol project
Comments
overfelt
added a commit
to eagles-project/scream
that referenced
this issue
Jun 18, 2024
There were two issues to be addressed: Use lambdas instead of functions in some Kokkos::parallel_for loops over team members. Fuse some Kokkos::parallel_for loops to improve efficiency.
E3SM-Bot
added a commit
that referenced
this issue
Jun 25, 2024
…_2858 Automatically Merged using E3SM Pull Request AutoTester PR Title: Addresses some suggestions in issue #2858. PR Author: overfelt PR LABELS: BFB, AT: AUTOMERGE, code cleanup, EAGLES, MAM
jgfouca
added a commit
that referenced
this issue
Aug 22, 2024
…ownstream_merge_2024_06_26 * downstream/master: (473 commits) remove redundant operation, fix the python library path in ruby cmake EAMxx: bump micro version of pyeamxx EAMxx: add timers to output manager on a per-yaml-file basis EAMxx: fix compiler warning Revert "EAMxx: add buildnml-time check for IC file and cmake option compatibility" Reduces buffer size by 1 for shoc small kernels Updating to SCORPIO v1.6.4 EAMxx: remove empty if statement in jenkins bash script Addresses some suggestions in issue #2858. EAMxx: fix typo in dummy XML selector for scripts unit tests EAMxx: fix sneaky error when parsing string in buildnml EAMxx: use special selector for cime scripts test EAMxx: fix invocation of cime-nml-tests in jenkins script Fix baselines_to_be_generated Remove unnecessary upstream master merge test-all-scream: Simplify the baseline model EAMxx: add buildnml-time check for IC file and cmake option compatibility Update EKAT submodule EAMxx: fix relative humidity unit test EAMxx: fix usage of code deprecated in Kokkos 4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here is the list of issues that must be fixed in the ACI code after the PR #2794 is merged:
w_variance
andcldfrac_liq_prev
from the SHOC interface.@bartgol's comment:
@bartgol's comment:
top_lev
is a namelist variable. We should add code to compute it based on pressure levels.The text was updated successfully, but these errors were encountered: