Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atmchange/atmquery use case for missing initial condition #2907

Open
jgfouca opened this issue Jul 16, 2024 · 2 comments
Open

atmchange/atmquery use case for missing initial condition #2907

jgfouca opened this issue Jul 16, 2024 · 2 comments
Assignees

Comments

@jgfouca
Copy link
Member

jgfouca commented Jul 16, 2024

@AaronDonahue wanted to do an atmchange on initial_conditions::qi.

% ./atmchange initial_conditions::qi=0.0
ERROR: initial_conditions::qi did not match any items

The reason is initial_conditions::qi is not in namelist_scream.xml is because in namelist_defaults_scream.xml:

    <qi hgrid="ne256np4|ne1024np4">0.0</qi>

The grid check fails so qi is just omitted and then is not usable by atmchange. We maybe need a smarter system to handle this case (qi is in the xml but is flagged as skip?) or the ability to append child elements, probably the latter.

@AaronDonahue
Copy link
Contributor

I would be in favor of being able to add child members. My understanding is that if a user adds an unused child parameter it will just be ignored in the actual run, so we may want to add a WARNING that this is a power user function where typos may lead to unexpected behavior.

@bartgol
Copy link
Contributor

bartgol commented Jul 25, 2024

In my long todo list, I want to change how we specify constant IC for fields. Namely, I want to have

   constant_fields:
     - f1 = 0.0
     - f2 = 0.2
     - f3 = (0.1, 0.2) 

where the latter is a vector quantity. This would mean that the XML entry is simply

<constant_fields type="array(string)"/>

which we can then always append to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants