Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in paste0(location, filename, "_groups") : cannot coerce type 'closure' to vector of type 'character' #30

Open
DirtyHarry80 opened this issue Apr 13, 2020 · 6 comments

Comments

@DirtyHarry80
Copy link

Hi,
I followed your example starting from per-existing Seurat Object. Function "Improved_Seurat_Pre_Process" executed without any problems. However there is something wrong with the next step (which by the way there is no explanation in the Documentation why we need that in the first place???):
filename="PBMC_example"
write.table(newFiles$newExpressionFile, paste0(location, filename, "_expression"), sep="\t")
write.table(newFiles$newFullExpressionFile, paste0(location, filename, "_fullExpression"), sep="\t")
write.table(newFiles$newGroupsFile, paste0(location, filename , "_groups"), sep="\t", col.names = F)

The error reads:
Error in paste0(location, filename = filename, "_groups") :
cannot coerce type 'closure' to vector of type 'character'

Same happens when one directly executes "Main_Doublet_Decon" function. The error is:
Error in paste0(location, filename, ".log") :
cannot coerce type 'closure' to vector of type 'character'

What is going on, any idea?

@EDePasquale
Copy link
Owner

Hi,

Could you please let me know what is being stored as "location" in your code? I have a feeling it is not a character, which is what paste0 is expecting, but I wouldn't know exactly what the problem is without seeing the object and type.

Best,
Erica

@DirtyHarry80
Copy link
Author

DirtyHarry80 commented Apr 22, 2020 via email

@EDePasquale
Copy link
Owner

Hi Andrei,

I'm glad you were able to get the script working. I'll be happy to help you with the interpretation of the heatmap but I'm not seeing it attached.

There are 2 types of heatmaps that can be generated in DoubletDecon: the cluster merging heatmap and the expression heatmap. Interpretation of the expression heatmap is easier to explain, as if you have heatmap=TRUE you will generate gene by cell heatmaps in the following order: original heatmap of all cells, heatmap of cells called as doublets, then heatmap of cells called as singlets (the last would be missing any genes removed as cell cycle gene clusters if that option was selected).

The second heatmap is the cluster merging heatmap, and I agree that it is not well defined in the original paper. I am in the process of publishing a protocol which has a lot more detail on the selection of these parameters and interpretation. If you would like I can send you the latest draft in an email, just let me know. Please see the following issues in this github for more information on choosing the rhop value (which is what this second heatmap is for):

For your second point, one of our lab members did this and I can check with him to make sure I am giving you the correct answer. I can see doing this by either by using the coordinates from Seurat and regenerating with those or by replacing the cluster calls within the Seurat object. Alternatively, you can use the DoubletDeconUI to create the doublet/singlet UMAPs but they will not be on the original Seurat layout and may be less helpful for you.

Best,
Erica

@DirtyHarry80
Copy link
Author

DirtyHarry80 commented Apr 22, 2020 via email

@EDePasquale
Copy link
Owner

EDePasquale commented Apr 22, 2020

I have sent it via email to a professional email address you have listed. Please let me know if you didn't receive it. I'll be happy to get it out in the public soon!

Edit: The email was rejected. If you could email me at [email protected] I will respond with the attachment ASAP.

@DirtyHarry80
Copy link
Author

DirtyHarry80 commented Apr 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants