CLM_USRDAT_NAME NOT being set in FATES NEON user-mods

[ekluzek]

Brief summary of bug

Because of #1949 we ended up not setting CLM_USRDAT_NAME in the FATES NEON user-mods and we need
to do that for the sites that change the year end.

General bug information

CTSM version you are using: ctsm5.1.dev128

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: NEON sites with FATES that change the year end by the site name

[ekluzek]

Here's the difference in defaults/shell_commands between FATES and non-FATES...

(ctsm_pylib) FATES/defaults> diff -wbcr shell_commands  ../../defaults/ 
*** shell_commands	2023-05-22 13:36:53.826324000 -0600
--- ../../defaults/shell_commands	2023-06-20 08:29:57.045786000 -0600
***************
*** 1,6 ****
  #!/bin/bash
  ./xmlchange CLM_USRDAT_NAME=NEON
! # CLM_USRDAT_NAME can also be set to NEON.PRISM
  ./xmlchange CCSM_CO2_PPMV=408.83
  # Set data forcing data to future scenario so will have data from 2018 to present-day
  ./xmlchange DATM_PRESAERO=SSP3-7.0
--- 1,6 ----
  #!/bin/bash
  ./xmlchange CLM_USRDAT_NAME=NEON
! # CLM_USRDAT_NAME can be set to either NEON or NEON.PRISM
  ./xmlchange CCSM_CO2_PPMV=408.83
  # Set data forcing data to future scenario so will have data from 2018 to present-day
  ./xmlchange DATM_PRESAERO=SSP3-7.0
***************
*** 11,16 ****
--- 11,17 ----
  # Set years to run forcing data over
  ./xmlchange DATM_YR_ALIGN=2018,DATM_YR_END=2021,DATM_YR_START=2018
  compset=`./xmlquery COMPSET --value`
+ CLM_USRDAT_NAME=`./xmlquery CLM_USRDAT_NAME --value`
  # For a transient case run the whole length and don't cycle
  if  [[ $compset =~ ^HIST ]]; then
    ./xmlchange DATM_YR_END=2022
***************
*** 23,27 ****
--- 24,36 ----
    ./xmlchange CLM_NML_USE_CASE="2018_control"
  fi
  
+ # If needed for SP simulations: turn off lightning & set history file variables
+ if  [[ $compset == *'SP_SICE'* ]]; then
+   ./xmlchange STOP_OPTION=nyears
+   ./xmlchange CLM_FORCE_COLDSTART=on
+ 
+   echo "hist_fincl2 = 'FCEV','FCTR','FGEV','FIRA','FSA','FSH','FPSN','H2OSOI','SNOW_DEPTH','TBOT','TSOI'" >> user_nl_clm 
+ fi
+ 
  # Explicitly set PIO Type to NETCDF since this is a single processor case (should already be set this way)
  ./xmlchange PIO_TYPENAME=netcdf

The "SP_SICE" part should probably go in for FATES, but maybe look a little different. I think the setting of CLM_USRDAT_NAME, needs to be in the FATES version though...

[wwieder]

Thanks Erik, I agree setting CLM_USRDAT_NAME, needs to be in the FATES version. Thanks for catching this. Let's not worry about the SP if statement, as the tutorial we have works correctly for creating a FATES-sp case. Message ID: ***@***.***>

…

[ekluzek]

This was fixed in ctsm5.1.dev129