Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LILAC option in build-namelist for --driver doesn't correctly test that lnd_frac is set #2857

Closed
ekluzek opened this issue Nov 1, 2024 · 1 comment · Fixed by #2853
Closed

LILAC option in build-namelist for --driver doesn't correctly test that lnd_frac is set #2857

ekluzek opened this issue Nov 1, 2024 · 1 comment · Fixed by #2853
Assignees
@ekluzek
Labels
bug something is working incorrectly closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix usability Improve or clarify user-facing options
Milestone
cesm3_0_beta05

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Nov 1, 2024

Brief summary of bug

There's a logic bug in the check that when "--driver lilac" option is used that lnd_frac is also set.

General bug information

CTSM version you are using: ctsm5.3.009, but goes back three years ago

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: LILAC

Details of bug

This line is incorrect...

https://github.com/ESCOMP/CTSM/blob/ctsm5.3.009/bld/CLMBuildNamelist.pm#L1985
@ekluzek ekluzek added bug something is working incorrectly usability Improve or clarify user-facing options labels Nov 1, 2024
@ekluzek ekluzek added this to the cesm3_0_beta05 milestone Nov 1, 2024
@ekluzek ekluzek self-assigned this Nov 1, 2024
@ekluzek ekluzek linked a pull request Nov 1, 2024 that will close this issue
Update submodules to ones that are based on cesm3_0_alpha04a #2853
Merged
@ekluzek ekluzek added the closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix label Nov 2, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 2, 2024

I was wrong about this, it isn't actually a problem.

@ekluzek ekluzek closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
bug something is working incorrectly closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix usability Improve or clarify user-facing options
Projects
LMWG: Near Term Priorities
Status: Done
Milestone
cesm3_0_beta05
Development

Successfully merging a pull request may close this issue.

Update submodules to ones that are based on cesm3_0_alpha04a ekluzek/CTSM
1 participant
@ekluzek