Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have tests that test ALL of the FATES logical namelist switches in CTSM #2902

Open
2 tasks
ekluzek opened this issue Dec 5, 2024 · 2 comments
Open
2 tasks
Assignees
Labels
blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability test: fates Pass fates test suite before merging testing additions or changes to tests

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 5, 2024

To make sure we test ALL of the important FATES options we want to add testing for them in a testmod that's in the FATES test suite. Preferably this would be in one kitchen sink testmod that does them all at once.

We talked about this idea in #2151 when switches where in the parameter file. Now switches are going to be moved to the namelist file, so it should be handled there.

The FATES issue: NGEET/fates#1295 must be resolved first

Definition of Done:

  • Try running with all the different options on all at once ("kitchen sink" test) and make sure it doesn't blow up
  • PR for new testmods for all the options
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability testing additions or changes to tests blocked: dependency Wait to work on this until dependency is resolved next this should get some attention in the next week or two. Normally each Thursday SE meeting. test: fates Pass fates test suite before merging labels Dec 5, 2024
@ekluzek ekluzek added this to the CESM3 Answer changing freeze milestone Dec 5, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 5, 2024

@glemieux I assigned you here, but it doesn't have to be you. And I added next so we can discuss later in the group.

@glemieux
Copy link
Collaborator

glemieux commented Dec 6, 2024

@ekluzek given that there are some FATES namelist checks to make some switches mutually exclusive, I'm thinking we'd need to have a few variants of these kitchen sink tests.

@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability test: fates Pass fates test suite before merging testing additions or changes to tests
Projects
None yet
Development

No branches or pull requests

3 participants