Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genbank tm shorthand unknown #94

Open
a-lewis-acid opened this issue Jan 7, 2025 · 5 comments
Open

Genbank tm shorthand unknown #94

a-lewis-acid opened this issue Jan 7, 2025 · 5 comments

Comments

@a-lewis-acid
Copy link

When I submit an annotated Genbank file to the API with an annotation to constrain the melting temperature of a region it returns "Program error: Unknown specification tm".

E.g. @tm(50-55C)

Is this a bug or is the tm specification meant to be used in a different way to that described in the API notes?

@veghp
Copy link
Member

veghp commented Jan 8, 2025

Thank you for bringing attention to this, I managed to reproduce this issue (probably EnforceMeltingTemperature is missing from https://github.com/Edinburgh-Genome-Foundry/DnaChisel/blob/master/dnachisel/builtin_specifications/__init__.py#L58 or along those lines). I'll address this in the coming days.

veghp added a commit that referenced this issue Jan 9, 2025
@a-lewis-acid
Copy link
Author

Thank you for looking into this.

Does the web app require the dev branch to be merged into the master branch for the fix to take effect?

@veghp
Copy link
Member

veghp commented Jan 22, 2025

Yes it needs to be merged, but more importantly the website needs to be built again. For that I'll have to update the website code and packages as well, so it will take quite some time unfortunately..

@Zulko
Copy link
Member

Zulko commented Jan 22, 2025

If the app update is a blocker, note that pip install dnachisel[reports] installs everything needed to do the same as the web app, in particular it installs a CLI that accepts annotated genbanks:

>>> dnachisel annotated_record.gb optimization_report/

So this would just require a new pypi release with the fix (or installing from the dev branch).

@veghp
Copy link
Member

veghp commented Jan 22, 2025

Yes, I can make a new release (probably only next week though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants