Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute rules even after a crash reboot #555

Open
stumbaumr opened this issue Oct 16, 2024 · 8 comments
Open

Execute rules even after a crash reboot #555

stumbaumr opened this issue Oct 16, 2024 · 8 comments

Comments

@stumbaumr
Copy link

Hi,
as I still get crash reboots sometimes which disables my otherwise correctly working rules I propose an option in the settings:
"Disable rules on crash reboot" with default on.

My uptime is high, but I still have to look like every day at least once if the rules are still active.

grafik

@stumbaumr
Copy link
Author

@IgorYbema , @CurlyMoo , any thoughts on this?

@CurlyMoo
Copy link
Contributor

CurlyMoo commented Nov 2, 2024

Good idea. But i want to suggest to having it by default off.

@stumbaumr
Copy link
Author

So the text would be "Enable rules on crash reboot" with default off?

@stumbaumr
Copy link
Author

Most users with rules have no crash problem - so they do not need that setting.
On the other hand if they experience a crash boot loop caused by their rules, they want their rules disabled on crash by default. My and McMagellans rules can crash - but the cause is known and accepted. If we get a crash boot loop we know how to reset the device to unset that setting.

So my belief is that it should be by default off (no rules activated after crash reboot).

@CurlyMoo
Copy link
Contributor

CurlyMoo commented Nov 3, 2024

PR is made:
IgorYbema#143

Copy link

github-actions bot commented Dec 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 4, 2024
@stumbaumr
Copy link
Author

This should be merged…

@github-actions github-actions bot removed the Stale label Dec 5, 2024
@erikrozendaal
Copy link

Please merge this. I've a set of rules that runs stably for multiple days but then crashes somewhere in the rules (no idea why), so it should be safe to reload the rules in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants