Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ability to turn off evolution for variables at runtime #246

Open
SamuelCupp opened this issue Nov 6, 2023 · 0 comments

Comments

@SamuelCupp
Copy link
Contributor

In Carpet, I could control which variables would actually evolve based on what I registered with MoL. This means that for e.g. IllinoisGRMHD I could select to only evolve the extra entropy or tabulated EOS variables if I'm actually using them.

In CarpetX, I am not aware of how to do this. If I have ent_star and ent_star_rhs in the interface.ccl and set the tags, the code fails at CycleTimeLevels due to the variable being invalid. I can easily fix this by adding a function that just writes 0 to everything at the same place the RHS are calculated. However, a preferred option would be to somehow control whether the variable should be evolved. Alternatively, if STORAGE is ever made to not be always on, then hopefully it would include logic to handle this since entropy evolution variables are only given storage if (evolve_entropy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant