Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom last-successful action by inline curl job #5

Open
rhaas80 opened this issue Oct 4, 2022 · 2 comments
Open

replace custom last-successful action by inline curl job #5

rhaas80 opened this issue Oct 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@rhaas80
Copy link
Member

rhaas80 commented Oct 4, 2022

Instead of using customized last-successful action, embed the required json parsing into action yaml file to reduce external dependencies:

curl -s https://api.github.com/repos/rhaas80/einsteintoolkit/actions/runs | jq 'first(.workflow_runs[] | select(.path==".github/workflows/docs.yml", .status=="success")) | .head_commit.id' | sed 's/\"//g'

gives the required last successful git hash.

This is basically the same as what the javascript in https://github.com/rhaas80/last-successful-commit-action/blob/master/dist/index.js does.

@rhaas80
Copy link
Member Author

rhaas80 commented Oct 4, 2022

actually do this via a repository_dispatch action option. Something like in carpetx-tests: https://github.com/EinsteinToolkit/carpetx-tests/blob/7e95b32e5b558d125c288b3271193db7b19dcdfc/.github/workflows/CI.yml#L8 this will avoid confusion between this programmatic dispatch and a user's manual dispatch

@nadinekuo
Copy link
Collaborator

This is related to the docs.yml file under .github/workflows

@rhaas80 rhaas80 added the enhancement New feature or request label Mar 16, 2023
nadinekuo pushed a commit to nadinekuo/einstein-toolkit-tests that referenced this issue Apr 6, 2023
Submodule repos/Scalar 17e7d57..d17622f:
  > Merged in proposal_ET_2023_05 (pull request EinsteinToolkit#5)
einsteintoolkit-updater pushed a commit that referenced this issue Apr 6, 2023
Submodule repos/Scalar f1e641e..d17622f:
  > Merged in proposal_ET_2023_05 (pull request #5)
einsteintoolkit-updater pushed a commit that referenced this issue Nov 15, 2023
Submodule repos/GRHayL f7dd5fc..dd0ff80:
  > PPM cleanup (#57)
Submodule repos/GRHayLET 3506b57..a5db0c2:
  > Merge pull request #5 from GRHayL/ppm_cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants