Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Verifiers should validate the Manifest, ContestDescription, and SelectionDescription crypto_hash #249

Open
1 task done
JohnLCaron opened this issue Mar 18, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@JohnLCaron
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

Currently, a verifier does not need to recompute the crypto_hash of Manifest, ContestDescription, or SelectionDescription. Those are not currently included in the election record, except indirectly in the SubmittedBallot objects.

It may be useful for a verifier to have the ability to recompute the crypto_hash, as a check against possible manipulation, and check those against what is explicitly included in the election record Manifest.

See Issue #243 for motivation.

Possible Implementation

Currently a verifier not using the reference library has to reverse engineer the hash function in the reference library.

Im not sure if something better can be done about that, or if hash.py is a good enough "spec".

Similarly, there is some wiggle room about which fields are included in the hash, and their order. Again, we could just let the reference library be the spec or we could document it more formally. In either case, the reference library could only make changes to the crypto_hash on a major (breaking) version change.

Anything else?

No response

@JohnLCaron JohnLCaron added enhancement New feature or request triage Waiting to be triaged labels Mar 18, 2022
@keithrfung keithrfung added documentation Improvements or additions to documentation and removed triage Waiting to be triaged labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants