Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2182: avoid double accumulation in *MixedDuplicated #2262

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

danielwe
Copy link
Contributor

@danielwe danielwe commented Jan 12, 2025

I added nonzero dvals to all the tests that hit any of the branches within the modified code block. Everything passes with this change. However, I don't understand the wider context of this code very well, so please review carefully and consider whether this is the appropriate fix.

It would probably be a good idea to systematically add nonzero dvals to most/all reverse mode tests, but I'll leave it here for now.

Fixes #2182

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (037dfed) to head (9360f38).
Report is 333 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2262      +/-   ##
==========================================
+ Coverage   67.50%   75.36%   +7.85%     
==========================================
  Files          31       56      +25     
  Lines       12668    16734    +4066     
==========================================
+ Hits         8552    12612    +4060     
- Misses       4116     4122       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit 70a2940 into EnzymeAD:main Jan 13, 2025
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect derivative from bug in jitrules.jl: nonzero dval added twice
3 participants