Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loop in parseOBDCommand does not end after finding correct entry in PID array #19

Open
JonaAnders opened this issue May 3, 2022 · 0 comments
Open

Loop in parseOBDCommand does not end after finding correct entry in PID array #19

JonaAnders opened this issue May 3, 2022 · 0 comments

Comments

@JonaAnders
Copy link

In lib/obd.js line 140, there should be a break for performance reasons. I know this is not a huge issue, but it takes nearly no effort to fix. I will make a pull request for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonaAnders