Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGD: prevent doubles #50

Open
ErwinKomen opened this issue May 2, 2022 · 1 comment
Open

WGD: prevent doubles #50

ErwinKomen opened this issue May 2, 2022 · 1 comment
Assignees
Milestone

Comments

@ErwinKomen
Copy link
Owner

Make sure no 'doubles' are read into the db.
A double is an entry that is identical to one that has already been read (i.e. the Entry fields are identical to one that has already been read).

@ErwinKomen ErwinKomen added this to the WGD-grant milestone May 2, 2022
@ErwinKomen ErwinKomen self-assigned this May 2, 2022
@ErwinKomen
Copy link
Owner Author

ErwinKomen commented May 4, 2022

I added the following code to excel_to_fixture():

Check if this contains the same information as the previous one
if iValid == 0:
    iValid = isLineEqual(oLine, oPrevious)

This means that doubles are not read further into the interface.
The only problem with skipping entries (doubles) is that information kind of gets lost.
This leads us to the larger 'problem' of trackability of entries.
Right now it is not possible to find out what happened to a particular entry (dialectopgave), given its reference number from the filled-in card.

Resolution to te above

  1. Add a table Opgave that contains fields: entry (FK) and reference (the reference number)
  2. When entering the information,
    1. every line with a reference number gets a record in Opgave
    2. only those that are part of an entry that fulfills all criteria get a FK to Entry
    3. entries that are equal (same lemma/trefwoord/dialectwoord/dialect) point to the same Entry

I haven't implemented the above (yet).
If this is desirable, then turn it into a new point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant