Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass inflow input requirements are inconsistent #1428

Open
mbkuhn opened this issue Dec 31, 2024 · 0 comments
Open

Mass inflow input requirements are inconsistent #1428

mbkuhn opened this issue Dec 31, 2024 · 0 comments
Labels
bug:amr-wind Something isn't working

Comments

@mbkuhn
Copy link
Contributor

mbkuhn commented Dec 31, 2024

Bug description

When using mass_inflow as a boundary condition, the velocity values at that boundary are not required (because queryarr is used), but the scalar values are required (because getarr is used). See links below. This leads to a confusing situation when boundary planes are used, because temperature input values are required even though they will be overwritten by boundary planes. It also means that the velocity values could be accidentally left off an input file for simulation where they are needed (e.g. not with boundary planes, and without a UDF specified).

https://github.com/Exawind/amr-wind/blob/main/amr-wind/boundary_conditions/BCInterface.cpp#L279

https://github.com/Exawind/amr-wind/blob/main/amr-wind/boundary_conditions/BCInterface.cpp#L369

Steps to reproduce

This behavior is seen in any of the _input regression tests, where a temperature value is required as an input for domain boundaries that will have temperature supplied through the boundary planes.

Expected behavior

Ideally, the boundary fills (like boundary planes and MPL) would be smart enough to indicate when certain variables are already covered by the fill routine, and a constant is not needed as an input. E.g. if boundary plane input is on, and temperature is one of the variables, then the temperature input line will not be required (and a warning would arise if it was included), but if it isn't one of the variables, then the temperature input line would be required.

@mbkuhn mbkuhn added the bug:amr-wind Something isn't working label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:amr-wind Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant