Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script to match result of FDP_SCRIPT #34

Open
kzscisoft opened this issue Jan 13, 2022 · 6 comments
Open

Update script to match result of FDP_SCRIPT #34

kzscisoft opened this issue Jan 13, 2022 · 6 comments
Labels
enhancement New feature or request more info needed

Comments

@kzscisoft
Copy link
Collaborator

The CLI will in future provide the variable FDP_SCRIPT pointing to the path of the script during a run, this should be used to determine the script file type in:
https://github.com/FAIRDataPipeline/pyDataPipeline/blob/dev/fairdatapipeline/pipeline.py#L178

Related to FAIRDataPipeline/FAIR-CLI#197.

@kzscisoft kzscisoft added the enhancement New feature or request label Jan 13, 2022
@bobturneruk
Copy link

# TODO: Change to Batch?

@kzscisoft
Copy link
Collaborator Author

This relates to the fact that the CLI provides the environment variable FDP_SCRIPT which should be used by the API for retrieval of the working script:
https://github.com/FAIRDataPipeline/FAIR-CLI/blob/346ca2db58aedd504704fb4a428decdddf225dc4/fair/user_config/__init__.py#L677

@bobturneruk
Copy link

Thanks @kzscisoft! Myself, @bruvio and @RyanJField will have a chat about this.

@bruvio
Copy link
Collaborator

bruvio commented Feb 15, 2022

ok. I still do not understand all this. but it is ok

@bobturneruk
Copy link

Thanks for noting that @bruvio. Sorry to disturb you again, but is there any documentation we can look at @kzscisoft to better understand this issue, please?

@RyanJField
Copy link
Collaborator

RyanJField commented Feb 15, 2022

Currently pipeline.py registers the script file extension as .py: Pipeline Line 184. However when using fair run and the script: block in a yaml, the script runs through a shell script (.sh) and needs to be registered as one (script.sh). Therefore pipeline.py needs to read the file extension when registering the script to the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request more info needed
Projects
None yet
Development

No branches or pull requests

4 participants