Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down "Test pit/match form" dialog so user can't navigate away inside the dialog #268

Open
JL102 opened this issue Oct 18, 2024 · 0 comments
Labels
Complexity - 2 Medium Issue is estimated to require a moderate amount of code changes, affecting multiple files. enhancement New feature or request. Importance - 2 Moderate An issue that makes the app more difficult to use.

Comments

@JL102
Copy link
Collaborator

JL102 commented Oct 18, 2024

The fact that you can navigate away from the test-form page inside the dialog can lead to confusion:

I'm trying to make a pit scouting form. I paste the JSON into the text box and click the "Test Form" button. It opens the dialog window as advertised. When I then click the "Submit" button on that dialog, it says "Submitted Data Successfully", but then redirects me to the Admin Dashboard inside the dialog box. If I refresh, it takes me back to the form entry page with the example JSON (outside the dialog). If instead I click the "One-off pit scouting" button, it takes me to a blank pit scouting page inside the dialog, with only the basic information and the "Refresh with team photos" button. Clicking it just changes some text. Refreshing the web page here does the same thing as refreshing it after submitting the form.

Maybe a way to fix this is to disable all links on the test form page, or simply disable the submit button and render the page without the navigation bar.

@JL102 JL102 added enhancement New feature or request. Complexity - 2 Medium Issue is estimated to require a moderate amount of code changes, affecting multiple files. Importance - 2 Moderate An issue that makes the app more difficult to use. good first issue Good for newcomers. and removed good first issue Good for newcomers. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity - 2 Medium Issue is estimated to require a moderate amount of code changes, affecting multiple files. enhancement New feature or request. Importance - 2 Moderate An issue that makes the app more difficult to use.
Development

No branches or pull requests

1 participant