Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Delete Orders #5

Closed
3 tasks done
mee4895 opened this issue Dec 15, 2017 · 1 comment
Closed
3 tasks done

Fix Delete Orders #5

mee4895 opened this issue Dec 15, 2017 · 1 comment
Assignees
@spethso
Labels
API new feature
Milestone
Fachschaftsrelease

Comments

@mee4895
Copy link
Member

mee4895 commented Dec 15, 2017 •
edited
Loading

The delete /orders/<orderID> does not work as planed:

  • When called with admin privileges it should revert the order by adding a new history entry which reverts the given orderID and adding the beverage back to the stock if the order was a beverage (this should be done with a simple string matching of the reason to the beverages)
  • When called with user privileges it should allow to only delete orders which are not older than 30sec (right now it deletes everything)
  • When a order is deleted the balance of the user must be corrected as well
@mee4895 mee4895 added this to the Fachschaftsrelease milestone Dec 15, 2017
@buehlefs buehlefs mentioned this issue Dec 20, 2017
Merged
@mee4895
Copy link
Member Author

mee4895 commented Jan 8, 2018

Closed by #22

@mee4895 mee4895 closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spethso spethso

Labels
API new feature
Projects
None yet
Milestone
Fachschaftsrelease
Development

No branches or pull requests
2 participants
@mee4895 @spethso