Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: E2E Tests fail for 4.15 #388

Closed
layaxx opened this issue Nov 16, 2023 · 3 comments · Fixed by #389
Closed

[BUG]: E2E Tests fail for 4.15 #388

layaxx opened this issue Nov 16, 2023 · 3 comments · Fixed by #389
Assignees
@layaxx
Labels
bug Something isn't working dependencies Pull requests that update a dependency file released

Comments

@layaxx
Copy link
Member

layaxx commented Nov 16, 2023

Describe the bug
Strapi 4.15 asks to install additional dependencies during the build process, making the tests fail

To Reproduce
Steps to reproduce the behavior:

  1. Run VERSION=4.15 envsubst < playground/templates/template.package.json > playground/package.json
  2. Run yarn
  3. Run yarn workspace playground build
  4. Build process asks for user input (causes e2e pipeline to fail)

Expected behavior
No user input required for build

System (please complete the following information):

  • OS: OpenSUSE Tumbleweed
  • Browser: n/a
  • Versions:
    • strapi: 4.15
    • strapi-plugin-translate: latest
    • provider: n/a
@layaxx layaxx added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 16, 2023
@layaxx layaxx self-assigned this Nov 16, 2023
layaxx added a commit that referenced this issue Nov 16, 2023
@layaxx
ci(e2e): fix e2e pipeline for strapi 4.15 by adding missing dependenc…
af6b910 
…ies to playground

strapi 4.15 complains during build process about missing (but non-required) dependencies, asking for
user input. This causes dhe pipelines to fail. this commit adds those dependencies

fix #388
@layaxx layaxx mentioned this issue Nov 16, 2023
Merged
@layaxx layaxx linked a pull request Nov 16, 2023 that will close this issue
ci(e2e): fix e2e pipeline for strapi 4.15 by adding missing dependenc… #389
Merged
@fekide-bot
Copy link

🎉 This issue has been resolved in version 1.0.11 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This issue has been resolved in version 1.2.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This issue has been resolved in version 1.1.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@layaxx layaxx

Labels
bug Something isn't working dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
2 participants
@layaxx @fekide-bot