From 06a49328c24cc53ed444468a65f03de68ab87992 Mon Sep 17 00:00:00 2001
From: Moritz Schott <moritz.schott@heigit.org>
Date: Thu, 26 Sep 2024 15:09:21 +0200
Subject: [PATCH 1/2] fix: prevent module from configuring the logger

as a module the tool should not temper with the logger but rather leave configuration to the user
---
 CHANGELOG.md            | 16 ++++++++++------
 ohsome/__init__.py      | 10 +++-------
 ohsome/test/__init__.py |  5 -----
 3 files changed, 13 insertions(+), 18 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cca1424..2d236cf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,8 +1,12 @@
 # Changelog
 
-## Unreleased
+## [Unreleased](https://github.com/GIScience/ohsome-py/compare/v0.3.3..master)
 
-## 0.3.3
+### Fixed
+
+- the module configuring the root logger on import causing users to be forced to overwrite the configuration.
+
+## [0.3.3](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.3)
 
 ### Fixed
 
@@ -17,7 +21,7 @@
 
 - init variable `data` to `OhsomeResponse`
 
-## 0.3.2
+## [0.3.2](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.2)
 
 ### Fixed
 
@@ -28,7 +32,7 @@
 - if tags are supplied for explosion in `response.as_dataframe`, the respective column will always be present in the resulting Geodataframe, even if the tags were not part of the result. In that case the column will be all-None ([#149](https://github.com/GIScience/ohsome-py/issues/149)).
 
 
-## 0.3.1
+## [0.3.1](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.1)
 
 ### Fixed
 
@@ -41,7 +45,7 @@
  - improved and sped up testing (first steps towards [#139](https://github.com/GIScience/ohsome-py/issues/139))
  - move metadata property from singleton to `cached_property`
 
-## 0.3.0
+## [0.3.0](https://github.com/GIScience/ohsome-py/releases/tag/v0.3.0)
 
 ### Added
 
@@ -63,7 +67,7 @@
  - support for pandas < 2.1
  - support for urllib3 < 2.1
 
-## 0.2.0
+## [0.2.0](https://github.com/GIScience/ohsome-py/releases/tag/v0.2.0)
 
 ### Added
 
diff --git a/ohsome/__init__.py b/ohsome/__init__.py
index c3e1646..757bca3 100644
--- a/ohsome/__init__.py
+++ b/ohsome/__init__.py
@@ -3,10 +3,6 @@
 
 """Ohsome API client for Python"""
 
-from .exceptions import OhsomeException
-from .response import OhsomeResponse
-from .clients import OhsomeClient
-import logging
-
-log_format = "%(asctime)s  %(module)8s  %(levelname)5s:  %(message)s"
-logging.basicConfig(level="INFO", format=log_format)
+from .clients import OhsomeClient  # noqa
+from .exceptions import OhsomeException  # noqa
+from .response import OhsomeResponse  # noqa
diff --git a/ohsome/test/__init__.py b/ohsome/test/__init__.py
index e814a30..241fb2a 100644
--- a/ohsome/test/__init__.py
+++ b/ohsome/test/__init__.py
@@ -1,8 +1,3 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
 """__description__"""
-
-import logging
-
-log_format = "%(asctime)s  %(module)8s  %(levelname)5s:  %(message)s"
-logging.basicConfig(level="DEBUG", format=log_format)

From 31881efd02d9d333228eef9b6aeefcec8053e8ff Mon Sep 17 00:00:00 2001
From: Moritz Schott <moritz.schott@heigit.org>
Date: Thu, 26 Sep 2024 15:22:53 +0200
Subject: [PATCH 2/2] fix: import order in __init__.py is not arbitrary

---
 ohsome/__init__.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ohsome/__init__.py b/ohsome/__init__.py
index 757bca3..181bcfe 100644
--- a/ohsome/__init__.py
+++ b/ohsome/__init__.py
@@ -3,6 +3,7 @@
 
 """Ohsome API client for Python"""
 
-from .clients import OhsomeClient  # noqa
+# The order of imports here must remain to prevent circular imports
 from .exceptions import OhsomeException  # noqa
 from .response import OhsomeResponse  # noqa
+from .clients import OhsomeClient  # noqa