Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all user-guide examples to confirm they work #101

Closed
trevorhardy opened this issue Mar 26, 2024 · 9 comments
Closed

Run all user-guide examples to confirm they work #101

trevorhardy opened this issue Mar 26, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@trevorhardy
Copy link
Contributor

In preparation for getting the User Guide example incorporated into the CI/CD we already have in place, we need to run through all the supported User Guide examples to make sure they work with the latest packages (including HELICS).

@trevorhardy trevorhardy added the enhancement New feature or request label Mar 26, 2024
@nathantgray
Copy link
Contributor

Filter clone example does not run because the file ControllerConfig.json does not exist. ControllerConfig.json is called on line 59:
fed = h.helicsCreateMessageFederateFromConfig("ControllerConfig.json")

@nathantgray
Copy link
Contributor

Filter federate has a halting problem. All federates will get stuck after requesting a time grant. The problem is not fixed when preventing the filter from dropping, delaying, interfering, or hacking.

@trevorhardy trevorhardy assigned nathantgray and unassigned ShatPNNL Jan 8, 2025
@trevorhardy
Copy link
Contributor Author

Filter clone example does not run because the file ControllerConfig.json does not exist. ControllerConfig.json is called on line 59: fed = h.helicsCreateMessageFederateFromConfig("ControllerConfig.json")

Added missing files that were just sitting on my computer and apparently had never been commited.

@trevorhardy
Copy link
Contributor Author

helics_connector using a direct matchfile (JSON or text) is not working for me.

@trevorhardy
Copy link
Contributor Author

Graphing in dynamic federation example is having some indexing problems.

@trevorhardy
Copy link
Contributor Author

Graphing in dynamic federation example is having some indexing problems.

Corrected and now working.

@trevorhardy
Copy link
Contributor Author

The following advanced examples are not currently working with their associated Github issue:

  1. Advanced multi-broker - HELICS issue #2721
  2. Advanced input and output - HELICS issue #2542
  3. Translators - HELICS issue #2562
  4. Connector matchfile direct - HELICS issue #2722

@trevorhardy
Copy link
Contributor Author

OK, I think I've got the examples that need help all tracked with their own HELICS-Examples issues:

  1. Fundamental native filter - Fix fundamental native filter example #122
  2. Fundamental filter federate - Fix fundamental filter federate example #123
  3. Advanced HELICS connector JSON matchfile - helics_connector example using JSON-formatted matchfile doesn't work #124
  4. Advanced multi-broker - HELICS multi-broker example not working #125
  5. Advanced input-output - Input-output example not working #126

Given this, I'm going to close out this general issue and push our work to the example-specific ones.

@nightlark
Copy link
Member

I think sub-issues are enabled if we want to create an issue to track the status of the related tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants