Replace organization logo URLs with uploaded images

[adborden]

User Story

In order to control the delivery of organization logos in CKAN and prevent broken images, data.gov operators want to replace any image URLs from CKAN2.3 with image uploads (in CKAN 2.8).

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

• WHEN I open my web browser to https://catalog.data.gov/organization/gsa-gov (or any organization page)
  AND I inspect the page source
  THEN I see the logo is served from a data.gov domain or a data.gov CDN

Background

Catalog never supported organization image uploads, you had to supply a URL. Some logos point to image in GSA/logo and some point to third-party resources (Wikipedia).

This causes problems when third-parties remove or change the image. Suddenly we'll start seeing broken links on catalog.data.gov organization pages.

In CKAN2.8, we can upload images directly to be served from CKAN.

Security Considerations (required)

None

Sketch

[Notes or a checklist reflecting our understanding of the selected approach]

[mogul]

This issue is Blocked as it can't start before #1886

[adborden]

I tested this on catalog-next and I'm still seeing a broken image.

[thejuliekramer]

@adborden this is a PR so it does not display a broken link for either upload or link url - once this is merged I can upload the images GSA/ckanext-datagovtheme#81

[adborden]

@thejuliekramer when you upload an organization image, where is it stored?

[FuhuXia]

Not complete.

Catalog is displaying the uploaded image. But image is stored at local instance: /var/lib/ckan/storage/uploads/group/...

Inventory is showing a broken image after upload. Image is stored at local instance /var/lib/ckan/files/storage/uploads/group/...

[mogul]

I'm going to remove this from the Epic since it is a standalone problem no resolved by the 2.8 rollout.