Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SMS message fragment counts in platform do not match calculated value #1125

Closed
anagradova opened this issue Jan 18, 2024 · 4 comments
Closed

Comments

@anagradova
Copy link
Contributor

Who discovered this?

Anastasia

What happened?

When exploring the calculation of SMS message fragments for multiple character sets, it became clear the calculation used by notification-utils produced a different segment count than should be expected.

Environment

production

What pages did this appear on?

/templates/add-sms

Detail the steps for someone to reproduce

Input a non-GSM and GSM combined char string into the message box and the SMS part calculator. It will produce different values.

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

@anagradova anagradova self-assigned this Jan 18, 2024
@github-project-automation github-project-automation bot moved this to 📋 New/Needs Review in Notify.gov product board Jan 22, 2024
@anagradova anagradova moved this from 📋 New/Needs Review to 👀 In review in Notify.gov product board Jan 22, 2024
@ccostino
Copy link
Contributor

Several adjustments have been made in notifications-utils and are now merged in the admin, so we should be able to see if the calculations are more accurate now!

@ccostino
Copy link
Contributor

@anagradova have you had a chance to take a look at this again and see if the calculations are now correct?

@ecayer
Copy link

ecayer commented May 30, 2024

@A-Shumway42 Is this related to your current work on message fragments? Thanks!

@xlorepdarkhelm xlorepdarkhelm moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Aug 29, 2024
@xlorepdarkhelm xlorepdarkhelm self-assigned this Aug 29, 2024
@xlorepdarkhelm xlorepdarkhelm moved this from 🏗 In progress (WIP: ≤ 3 per person) to ⬇ Up-Next in Notify.gov product board Aug 29, 2024
@xlorepdarkhelm xlorepdarkhelm removed their assignment Aug 29, 2024
@ccostino
Copy link
Contributor

This is still an issue, but it's going to be superseded by the work in GSA/notifications-api#1427, so we're closing it!

@github-project-automation github-project-automation bot moved this from ⬇ Up-Next to ✅ Done in Notify.gov product board Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants