From 4dace1f6e545eb0577b0486e390176bd90fe31a8 Mon Sep 17 00:00:00 2001 From: Martin Robertz Date: Thu, 9 Jan 2025 21:05:10 +0100 Subject: [PATCH 1/3] update --- dependencies.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dependencies.gradle b/dependencies.gradle index 47d19c113..bcf064173 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -1,8 +1,8 @@ // Add your dependencies here dependencies { - api('com.github.GTNewHorizons:CodeChickenCore:1.4.0:dev') - implementation('com.github.GTNewHorizons:GTNHLib:0.6.0:dev') + api('com.github.GTNewHorizons:CodeChickenCore:1.4.1:dev') + implementation('com.github.GTNewHorizons:GTNHLib:0.6.1:dev') shadowImplementation('org.apache.commons:commons-csv:1.10.0') } From fd08a93554789f81abeda56e3a317e5c3f09524b Mon Sep 17 00:00:00 2001 From: Caedis Date: Fri, 10 Jan 2025 08:42:23 +0000 Subject: [PATCH 2/3] Fix NPE in ItemsTooltipLineHandler (#589) --- src/main/java/codechicken/nei/ItemsTooltipLineHandler.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/codechicken/nei/ItemsTooltipLineHandler.java b/src/main/java/codechicken/nei/ItemsTooltipLineHandler.java index 110090029..24ddc58cf 100644 --- a/src/main/java/codechicken/nei/ItemsTooltipLineHandler.java +++ b/src/main/java/codechicken/nei/ItemsTooltipLineHandler.java @@ -123,6 +123,8 @@ private List groupingItemStacks(List items) { for (ItemStack stack : items) { final NBTTagCompound nbTag = StackInfo.itemStackToNBT(stack, true); + if (nbTag == null) continue; + final String GUID = StackInfo.getItemStackGUID(stack); if (!unique.containsKey(GUID)) { From 31173a1fbd249ce4adaad75feb52b64b33c0daea Mon Sep 17 00:00:00 2001 From: Glease <4586901+Glease@users.noreply.github.com> Date: Fri, 10 Jan 2025 17:11:52 +0800 Subject: [PATCH 3/3] fix memory leak fixes not working for MP (#590) #258 addresses the memory leak in ItemMobSpawner. Unfortunately the clean up handler is not consistently called on every world unloaded. This PR fixes this issue by moving the call out of that if block --- src/main/java/codechicken/nei/ClientHandler.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/codechicken/nei/ClientHandler.java b/src/main/java/codechicken/nei/ClientHandler.java index 50078c81f..6e51761e4 100644 --- a/src/main/java/codechicken/nei/ClientHandler.java +++ b/src/main/java/codechicken/nei/ClientHandler.java @@ -325,9 +325,8 @@ public void loadWorld(World world, boolean fromServer) { if (!Minecraft.getMinecraft().isSingleplayer()) // wait for server to initiate in singleplayer NEIClientConfig.loadWorld("remote/" + ClientUtils.getServerIP().replace(':', '~')); - - ItemMobSpawner.clearEntityReferences(world); } + ItemMobSpawner.clearEntityReferences(world); lastworld = world; }