Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen, picture height cut off #9

Open
mstaveley opened this issue Dec 13, 2022 · 8 comments
Open

Fullscreen, picture height cut off #9

mstaveley opened this issue Dec 13, 2022 · 8 comments

Comments

@mstaveley
Copy link

With ArtSaverApp in fullscreen mode.
Pictures that are portrait aspect ratio (height greater than width) have the top and bottom cut off because ArtSaverApp fills the width of the screen. Lots of cut off heads.

The expected behavior is to fill the height of the screen and place black bars on the sides.

When app not in fullscreen mode and window much wider than height, pics seems to be handled correctly. But if window is not much wider than height, pics height is cut off. BTW, this also happens with landscape pics, depending on window aspect ratio.

I can see an argument for this behaviour, but would like a preferences button to say "don't cut of height or width".

ArtSaverApp.app v3.2.zip

@GabZach
Copy link
Owner

GabZach commented Dec 13, 2022

Thanks a lot for your feedback.
I think i understand what you mean.

Because of the problem you described, I implemented the setting "Avoid black border" , which also has a slide that allows you to adjust how much is getting cut off.
Did you try that?

@mstaveley
Copy link
Author

I tried [Avoid black borders], it did not fix the problem on either full [less] or full [more]. I'm not sure what less or more mean in this context either. Does less have less black border or more black border. I think the confusion arises from the double negative of "Avoid" with "less".

It is also only available with [Zoom in/out] which I don't want.

@GabZach
Copy link
Owner

GabZach commented Dec 28, 2022 via email

@mstaveley
Copy link
Author

I would suggest, that if the aspect ratio of the image is different from the aspect ratio of the window (or screen in full screen mode - yes I know this is the same thing 😀) then don't cut any of the image off, instead expand the larger dimension to the size of the window and fill the top/bottom or sides with a black border.

@GabZach
Copy link
Owner

GabZach commented Jan 3, 2023 via email

@mstaveley
Copy link
Author

Yes, I think my suggestion still applies. Expand the image until one of the dimensions fits the window size in that dimension and fill the other dimension with black pixels.

@palijn
Copy link

palijn commented Mar 12, 2024

Hi,
has there been any progress on not cutting heads ? :)
Most pictures I want to display are ratio 1:1 on a Macbook Air M1 screen.
I'll be happy with black borders, however large, if the whole picture is displayed at some point. (Zoom&pan effects are nice, but not mandatory).
Thanks !

@GabZach
Copy link
Owner

GabZach commented Mar 12, 2024

I am very sorry, but I didn't find the time yet to work on that. But I realize that it needs to be solved.
There are other bugs, unfortunately, that need solving first.
But thanks so much for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants