From 70cb4c4ceb28850656dfa09ae765a821a0f76397 Mon Sep 17 00:00:00 2001 From: vindard <17693119+vindard@users.noreply.github.com> Date: Tue, 17 Oct 2023 09:41:35 -0400 Subject: [PATCH] chore: remove 'directories' attr from eslint rule --- core/api/BUCK | 1 - toolchains/workspace-pnpm/macros.bzl | 7 +------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/core/api/BUCK b/core/api/BUCK index ff15e39eff..b28366f93e 100644 --- a/core/api/BUCK +++ b/core/api/BUCK @@ -76,7 +76,6 @@ runnable_tsc_build_bin( eslint( name = "check-lint", srcs = [":src"] + [":test_src"] + glob([".eslint*"]), - directories = ["src", "test"], extensions = [".ts"], allow_warnings = True, ) diff --git a/toolchains/workspace-pnpm/macros.bzl b/toolchains/workspace-pnpm/macros.bzl index 6a8bccedb9..4a36045888 100644 --- a/toolchains/workspace-pnpm/macros.bzl +++ b/toolchains/workspace-pnpm/macros.bzl @@ -603,7 +603,7 @@ def eslint_impl(ctx: AnalysisContext) -> list[[ ExternalRunnerTestInfo, ]]: args = cmd_args() - args.add(ctx.attrs.directories) + args.add(".") args.add("--ext") args.add(",".join(ctx.attrs.extensions)) if ctx.attrs.allow_warnings == False: @@ -628,11 +628,6 @@ _eslint = rule( providers = [RunInfo], doc = """eslint dependency.""", ), - "directories": attrs.list( - attrs.string(), - default = [], - doc = """Directories under which to check.""", - ), "extensions": attrs.list( attrs.string(), default = [],