Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pr 760 #763

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Fix pr 760 #763

merged 6 commits into from
Aug 27, 2024

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Aug 27, 2024

Description

This PR fixes the use of reduce and sum for empty sets and a typo.

What type of PR is this? (check all applicable)

  • Bug Fix

Related Tickets & Documents

Fixes a change that I made on #760 and a typo.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

By running test_examples.jl inside the test folder of GenX.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

Copy link
Collaborator

@cfe316 cfe316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've tested both on standard cases and a case with no storage. Looks good.

@cfe316 cfe316 merged commit 9a59b65 into develop Aug 27, 2024
9 checks passed
@lbonaldo
Copy link
Collaborator Author

Thank you @cfe316.

@lbonaldo lbonaldo deleted the fix-pr-760 branch December 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants