Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTL: Collect metadata about the stream #1

Open
clone1018 opened this issue Jan 1, 2023 · 3 comments
Open

FTL: Collect metadata about the stream #1

clone1018 opened this issue Jan 1, 2023 · 3 comments

Comments

@clone1018
Copy link
Member

Fields normally used are:

type StreamMetadata struct {
	AudioCodec        string
	IngestServer      string
	IngestViewers     int
	LostPackets       int
	NackPackets       int
	RecvPackets       int
	SourceBitrate     int
	SourcePing        int
	StreamTimeSeconds int
	VendorName        string
	VendorVersion     string
	VideoCodec        string
	VideoHeight       int
	VideoWidth        int
}
@clone1018 clone1018 added this to the Glimesh Readiness Launch milestone Jan 1, 2023
@clone1018 clone1018 changed the title Collect metadata about the stream FTL: Collect metadata about the stream Jan 1, 2023
@nassah221
Copy link
Collaborator

nassah221 commented May 5, 2023

@clone1018 For clarity, do you think we do metadata collection at ftl ingress or after the local peer ingestor that we have for thumbnailer?

webrtc-stats was recently implemented with pion v3.2.0.which could be useful in providing the relevant metadata. Although, I think for this we would have to effectively pull metadata from the local webrtc ingestor. I'm not sure if that's really going to be useful.

@clone1018
Copy link
Member Author

Well, these metrics are used to debug the quality of the stream that the streamer is pushing to us. So they should exist either at, or right after the video ingestion layer (FTL / RTMP / SRT / etc). If we put it after the peer ingestor the numbers wouldn't be right. I ended up implementing a couple of these, but there's more work to do for sure.

@clone1018
Copy link
Member Author

Though, webrtc-stats will be crucial for debugging Glimesh => Viewer connections!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants