Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtraAttributesOauthClient field for google_iam_workforce_pool_provider resource #20862

Open
omkark-google opened this issue Jan 9, 2025 · 0 comments · May be fixed by GoogleCloudPlatform/magic-modules#12721
Labels

Comments

@omkark-google
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Add support for extra attributes oauth2 client fields to create workforce pool operation for SAML protocol. This address the gap between newly added support in Gcloud command of iam create workforce pool provider and iam update workforce pool provider.

New or Affected Resource(s)

  • google_iam_workforce_pool_provider

Potential Terraform Configuration

resource "google_iam_workforce_pool_provider" "example" {
  workforce_pool_id   = google_iam_workforce_pool.pool.workforce_pool_id
  location            = google_iam_workforce_pool.pool.location
  provider_id         = "example-prvdr"
  attribute_mapping   = {
    "google.subject"  = "assertion.sub"
  }
  saml {
    idp_metadata_xml  = "<?xml version=\"1.0\"?><md:EntityDescriptor xmlns:md=\"urn:oasis:names:tc:SAML:2.0:metadata\" entityID=\"https://sts.windows.net/12313-1231231-313131/\"><md:IDPSSODescriptor protocolSupportEnumeration=\"urn:oasis:names:tc:SAML:2.0:protocol\"> <md:KeyDescriptor use=\"signing\"><ds:KeyInfo xmlns:ds=\"http://www.w3.org/2000/09/xmldsig#\"><ds:X509Data><ds:X509Certificate>MIIDpDCCAoygAwIBAgIGAX7/5qPhMA0GCSqGSIb3DQEBCwUAMIGSMQswCQYDVQQGEwJVUzETMBEGA1UECAwKQ2FsaWZvcm5pYTEWMBQGA1UEBwwNU2FuIEZyYW5jaXNjbzENMAsGA1UECgwET2t0YTEUMBIGA1UECwwLU1NPUHJvdmlkZXIxEzARBgNVBAMMCmRldi00NTg0MjExHDAaBgkqhkiG9w0BCQEWDWluZm9Ab2t0YS5jb20wHhcNMjIwMjE2MDAxOTEyWhcNMzIwMjE2MDAyMDEyWjCBkjELMAkGA1UEBhMCVVMxEzARBgNVBAgMCkNhbGlmb3JuaWExFjAUBgNVBAcMDVNhbiBGcmFuY2lzY28xDTALBgNVBAoMBE9rdGExFDASBgNVBAsMC1NTT1Byb3ZpZGVyMRMwEQYDVQQDDApkZXYtNDU4NDIxMRwwGgYJKoZIhvcNAQkBFg1pbmZvQG9rdGEuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxrBl7GKz52cRpxF9xCsirnRuMxnhFBaUrsHqAQrLqWmdlpNYZTVg+T9iQ+aq/iE68L+BRZcZniKIvW58wqqS0ltXVvIkXuDSvnvnkkI5yMIVErR20K8jSOKQm1FmK+fgAJ4koshFiu9oLiqu0Ejc0DuL3/XRsb4RuxjktKTb1khgBBtb+7idEk0sFR0RPefAweXImJkDHDm7SxjDwGJUubbqpdTxasPr0W+AHI1VUzsUsTiHAoyb0XDkYqHfDzhj/ZdIEl4zHQ3bEZvlD984ztAnmX2SuFLLKfXeAAGHei8MMixJvwxYkkPeYZ/5h8WgBZPP4heS2CPjwYExt29L8QIDAQABMA0GCSqGSIb3DQEBCwUAA4IBAQARjJFz++a9Z5IQGFzsZMrX2EDR5ML4xxUiQkbhld1S1PljOLcYFARDmUC2YYHOueU4ee8Jid9nPGEUebV/4Jok+b+oQh+dWMgiWjSLI7h5q4OYZ3VJtdlVwgMFt2iz+/4yBKMUZ50g3Qgg36vE34us+eKitg759JgCNsibxn0qtJgSPm0sgP2L6yTaLnoEUbXBRxCwynTSkp9ZijZqEzbhN0e2dWv7Rx/nfpohpDP6vEiFImKFHpDSv3M/5de1ytQzPFrZBYt9WlzlYwE1aD9FHCxdd+rWgYMVVoRaRmndpV/Rq3QUuDuFJtaoX11bC7ExkOpg9KstZzA63i3VcfYv</ds:X509Certificate></ds:X509Data></ds:KeyInfo></md:KeyDescriptor><md:SingleSignOnService Binding=\"urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect\" Location=\"https://test.com/sso\"/></md:IDPSSODescriptor></md:EntityDescriptor>"
  }
  extra_attributes_oauth2_client {
    issuer_uri       = "https://accounts.thirdparty.com"
    client_id        = "client-id"
    client_secret {
        value {
          plain_text = "client-secret"
        }
      }
    attributes_type = "AZURE_AD_GROUPS_MAIL"
    query_parameters {
        filter      = "mail:gcp"
    }
  }
  display_name        = "Display name"
  description         = "A sample OIDC workforce pool provider."
  disabled            = false
  attribute_condition = "true"
}

References

No response

@github-actions github-actions bot added forward/review In review; remove label to forward service/iam-workforce labels Jan 9, 2025
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 9, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 9, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 9, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 9, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 11, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 11, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 11, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
omkark-google added a commit to omkark-google/magic-modules that referenced this issue Jan 11, 2025
fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant