Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets Unavailable #1

Closed
Paeyus opened this issue Mar 12, 2024 · 6 comments
Closed

Datasets Unavailable #1

Paeyus opened this issue Mar 12, 2024 · 6 comments

Comments

@Paeyus
Copy link

Paeyus commented Mar 12, 2024

The datasets used in the paper are not available in the repository for running the codes provided.

@GuangchenW
Copy link
Owner

Hi Paeyus,

The dataset used to be included in the arxiv of the related paper, but that seems to no longer be the case. I've committed the csv file to the repo, hope this helps.

@Paeyus
Copy link
Author

Paeyus commented Mar 13, 2024

Hello @GuangchenW ,

  1. I would like to find out, if it is possible to evaluate the objective value based on the new experimental points generated before conducting the actual experiment to verify (in BoTorch)

  2. And do you have an idea on how to deal with integer values?

@GuangchenW
Copy link
Owner

GuangchenW commented Mar 13, 2024

  1. If what you mean is to compute the posterior of the points acquired, you can simply call the posterior function on point x (See BoTorch doc on SingleTaskGP). This will give you the GP estimation of the output at x.

  2. I've not done optimization over discrete space, but the optimize_acqf_mixed function seems to address your need. Check out this issue on BoTorch GitHub. Alternatively, you can use the Ax interface to implement your own logic for integer parameters, though that may take some work.
    If you are not constrained to BoTorch, you can also check out EmuKit, which allows you to specify whether a paramter is continuous or discrete.

@Paeyus
Copy link
Author

Paeyus commented Apr 9, 2024

Hello @GuangchenW,
I checked out the document for 1. but I didn't see the code which points to that. Could you recheck and let me know?
I tried using the full Gaussian process code from GPyTorch (Not SingleTaskGP), and used the prediction code in the documentation, but it seems to make a prediction value that is lower than the best observed point in my data

@GuangchenW
Copy link
Owner

GuangchenW commented Apr 9, 2024

Hi @Paeyus, posterior is a member method of the botorch Model base class, which SingleTaskGP inherents from. If you ctrl+F search for posterior, you should be able to find the api definition.
I'm not so sure about your second question. I assume you are following https://docs.gpytorch.ai/en/v1.6.0/examples/01_Exact_GPs/Simple_GP_Regression.html? If this is the case, you are using ExactGP with GaussianLikelihood, which assumes noisy data, meaning you are doing regression and the mean won't land exactly on the given observations (the picture at the bottom of the tutorial page shows this phenomenon).

Also be careful about running into the XY Problem

@Paeyus
Copy link
Author

Paeyus commented Apr 10, 2024

Thank you very much, @GuangchenW. I am very grateful for your swift responses and assistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants