Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Log JSON API error messages #103

Open
pcraig3 opened this issue Dec 10, 2024 · 0 comments
Open

[WIP] Log JSON API error messages #103

pcraig3 opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels

Comments

@pcraig3
Copy link
Collaborator

pcraig3 commented Dec 10, 2024

⚠ Update: this issue is related to the JSON stuff, yes, but it more properly lives under a "logging" epic which I haven't created yet. ⚠


This issue is about what we do when we get an error message.

Ideally, we have all our validation logic & error message strings in models.py and they are being used by the API to return errors for bad inputs. That's all presumed by this issue.

This issue is about making sure that any errors users run into are also logged in our console, so that we can potentially find them later. There is another ticket about this (#90), so if we have settled on a format, we should follow it. If not, we should make sure messages are at least being spat out to the console.

All to say, our API routes should log errors when they see them, in addition to returning error messages to the user.

@pcraig3 pcraig3 added the API label Dec 10, 2024
@pcraig3 pcraig3 changed the title Log error messages JSON API Log JSON API error messages Dec 10, 2024
@jtmst jtmst self-assigned this Dec 18, 2024
@pcraig3 pcraig3 changed the title Log JSON API error messages [WIP] Log JSON API error messages Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants