-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19 update and future? #36
Comments
1.18.1 threw a lot of wrenches into the systems Atmosfera uses and updating it would be a huge burden. I don't have the time to commit to this project anymore but would be open to somebody else with the skills to do so taking over. |
I was kindly informed by a stranger on CurseForge about this. I'm not sure if I'm able to "take over" the mod and keep adding content but I can help out maintain the mod. I actually just pretty much finished porting the mod to 1.18.2 and 1.19 and everything seems to work just fine, though it could surely do with some more testing - I put up some test releases for that reason. Generally I find, the more members a project has, the easier it gets to keep it afloat. If you wanna add me to the project, I might ask Breki to help out a little too. |
@Haven-King I did ask Fourmisain to help out and he seems can help and he is a great dev with a good spirit. I hope you all can get along and continue this journey. |
@Fourmisain I would be happy to have you take over as maintainer of this project! I am out of town for the next few days and unable to test your fork, but if you open a PR just so we keep the changes all together, I will try to review it this weekend and add you to both the GitHub and CurseForge projects. |
@Fourmisain today I faced a fetal crash and I suspect it might be atmosfera building up memory leak and making game crash |
Those leaks are rendering related ( edit: Actually, it looks like |
Regarding the future of Atmosfera, i will also try to do my bit, as I like the mod too, and would like to see it more commonly used |
I guess illumination was the culprit of that crash but IDK maybe konkret update helped too |
IDK why I get so many memory leak. I even installed memory leak fix mod to combat any possible memory leak. but still there are so many logs like this: these are all the sound mods that I have but none of them have anything to do with fish ambient sounds(maybe sound physics remastered) also getting this error : full log file: |
I still doubt your memory leak is caused by Atmosfera, I have done some testing on this and didn't run into any issues, though I also cannot fully dismiss it - but not for the reasons you might be thinking. Sounds not ending and stuff like that will not cause a memory leak. Try to get rid of Farsight first and retest, that's still the most likely candidate. About those warnings:
That's Sodium trying it's best to fix the mess.
Those are completely normal, it's an ancient bug.
This just means the server is temporarily running slow. If your memory is nearly full and your game is chugging, this is to be expected.
You used Again, please try disabling mods one-by-one and do long play sessions to get an idea if one particular mod is causing the issue or not. |
By "memory nearly full" I mean the game's heap memory, you can see it if you press F3 on the top right. You'll see the numbers quickly rise and fall down again. When it's constantly at high values, you know very little free space is left and that's where the game starts chugging (and crashing).
I had that very chunk loading issue too in All of Fabric 5, not sure what that's caused by.
It's very unlikely it's Phosphor. If you still want high view distance, you can give Bobby a shot. |
So it's not just me. |
IDK if this kinda "add support" need to be done from that side of development or this side |
@Fourmisain btw have you seen charmonium mod? it has really good performance and sounds pick up really fast(biome and elevation detection is really fast) |
@Haven-King @Fourmisain any news on the state of this mod and future plans? |
Haven't come around porting to 1.19.3 yet, not sure when I'll be able to. This might take a little more effort since this is where Mojang started putting major technical changes into minor patches, which has it's pros and cons - though I feel like 1.19.2 is still perfectly viable to use in the meantime. |
Here's a 1.19.3 / 1.20 port: #39, release found inside. |
Hey, any info or willingness for 1.21(.1) update? Pity that the main dev died and didn't add people willing to update it as maintainers, as it kinda made Atmosfera dead... And it was such a great mod. It still is. Sadly - without updates. Anyways, 1.20 version works (?) on 1.21, except the mod menu config is borked, not sure how it plays out in game tho |
The mod was surprisingly unaffected by the massive NBT changes in 1.20.5 and all that broke in 1.21 was literally just Here's the port: #40 edit: |
Bro, did you just update a mod in less than an hour of some random dude asking online? 😭 I'm so gonna test it rn lmao |
Okay, so now that this one awesome person updated Atmosfera up to 1.21, how does it look like when used with Charmonium and/or MAmbience. I used it as a replacement, and sometimes along with Atmosfera, but not quite sure how well they go together. I do know there is stated conflict in mod json, but it'ws only conflicting, not breaking, so not sure if I should/can use it together... (Also still confused as to how you just did that update so quickly lmaooo, like that's crazyXD) |
Fourmisain is a great dev that I asked to help to keep this mod alive and
he is just awesome at it
Many thanks to him
<3 <3 <3
…On Thu, Aug 15, 2024, 3:43 PM Gregory ***@***.***> wrote:
Okay, so now that this one awesome person updated Atmosfera up to 1.21,
how does it look like when used with Charmonium and/or MAmbience. I used it
as a replacement, and sometimes along with Atmosfera, but not quite sure
how well they go together. I do know there is stated conflict in mod json,
but it'ws only conflicting, not breaking, so not sure if I should/can use
it together...
(Also still confused as to how you just did that update so quickly lmaooo,
like that's crazyXD)
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUULT62C7UO6U2UO7M6R623ZRSLOFAVCNFSM5ZC6COD2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMRZGEYTKOJRGMYA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Haven-King just added me as a maintainer and gave me push access on this repo! I'll start merging the PRs and publishing the releases to CurseForge. @Haven-King A bit of revenue share would be nice to have too if you haven't! |
@Fourmisain I've already assigned 100% of future revenue to you on CurseForge 🙂 You are welcome to create a Modinth page as well if you wish. |
Thanks a ton! |
Modrinth page is up and is already approved! |
Hello, can we get an update to 1.19 please?
Are there any plans to continue adding music from MC Dungeons? There have been a number of updates for MCD but nothing else was added to this mod. It it just lack of interest in updating this mod or is it something like time constraints? Because I would love to see more updates to this mod.
The text was updated successfully, but these errors were encountered: