Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron #246

Open
bradrn opened this issue Sep 30, 2020 · 6 comments
Open

Update Electron #246

bradrn opened this issue Sep 30, 2020 · 6 comments

Comments

@bradrn
Copy link
Contributor

bradrn commented Sep 30, 2020

threepenny-gui’s recommended package.json uses Electron version ^1.6.1. By contrast, the Electron quickstart package.json uses Electron version ^10.1.3 — nine major versions later! It looks like threepenny-gui desperately needs to upgrade its Electron version. To do this, the package versions in package.json would need to be upgraded; after that the provided electron.js will probably need to be changed as well, in order to keep it working with the updated package versions.

(This seems like a simple change, and I would submit a PR myself, except that (a) my knowledge of the node.js ecosystem is practically nonexistent, and (b) I cannot build threepenny-gui, and thus am unable to test any changes I may make. If by some miracle I manage to get everything working again, I can certainly try to submit a PR for this, but until then I can’t really do anything with threepenny-gui.)

@sjakobi
Copy link
Collaborator

sjakobi commented Oct 1, 2020

Unfortunately I'm also quite unfamiliar with Electron and the node ecosystem. I'd appreciate a PR!

@adi-mohan
Copy link

Hi! May I work on this issue?

@adi-mohan
Copy link

adi-mohan commented Oct 25, 2020

Also, you should almost never use electron in dependencies. It should be under devDependencies, reason being electron is not advised to install on production environment. I will initiate PR, whenever you respond to this. @bradrn @HeinrichApfelmus @sjakobi

@bradrn
Copy link
Contributor Author

bradrn commented Oct 25, 2020

I’d be happy for you to work on this issue, although it would be nice to have some comment from @HeinrichApfelmus on whether that’s OK (which I assume it is).

@HeinrichApfelmus
Copy link
Owner

@adi-mohan Yes, please! I'm not very familiar with the npm ecosystem, so any help is appreciated.

@bradrn
Copy link
Contributor Author

bradrn commented Feb 7, 2021

Update on this issue: I’ve been working recently on a threepenny-gui application in Electron, and I think I’ve managed to get it working with the latest versions of everything. I’d like to do a rewrite of the existing tutorial to get it a bit more up-to-date, but I think I’ll just wait a bit until I’m confident I’ve gotten everything working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants