Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set memory_verification value to cairo1 in the README example #163

Open
mellowcroc opened this issue Dec 11, 2024 · 0 comments
Open

Set memory_verification value to cairo1 in the README example #163

mellowcroc opened this issue Dec 11, 2024 · 0 comments

Comments

@mellowcroc
Copy link

The README example for calling verify-on-starknet.sh uses the strict option for memory_verification

./verify-on-starknet.sh 0x4ce7851f00b6c3289674841fd7a1b96b6fd41ed1edc248faccd672c26371b8c examples/calldata recursive keccak_248_lsb stone5 strict

This will result in the following error for all Cairo1 programs ('Invalid final_pc'), which is incomprehensible for most developers. Since the strict option is tailored for Cairo0 programs (which most devs won't use), set the default value to cairo1 instead? Or add more guidance in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant