Fixed icon updation for dark mode #133 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshit517
reviewed
Jan 9, 2025
ios/Podfile.lock
Outdated
There was a problem hiding this comment.
@sommye-ctr why were the dependencies updated?
Akshit517
approved these changes
Jan 14, 2025
|
@Akshit517 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #133
Type of Change
Put
xinside the square bracket to specify what type of change your PR is:Description of Change
The UI for dark mode button is now updating accordingly.
Implementation Details
Instead of using theme provider object, I am using a Consumer widget to also update the UI for any changes in the theme provider.