Location trigger#84 #148
Open
Location trigger#84 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sommye-ctr This doesn't make sense to me? Why would you mark a task as completed based on location? |
|
@pranavkonidena as discussed in the related issue, it is a feature which is quite niche and with the current implementation, it is not very useful. It could be useful if the user is given an option to select a location of his choice and on going there he would be notified of that specific task (or maybe mark it as complete on its own). I did not go with letting the user select a place of his own since it would require to setup apis and billing account(probably google maps). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #84
Type of Change
Put
xinside the square bracket to specify what type of change your PR is:Description of Change
Enables user to attach its current location to a task. On the next startup of app session, the user's current location is detected and if it is within 50 m of the location attached to the task - task is marked as completed.
Implementation Details
geolocatoris used to get location of the user and new fields -latandlngare added to task model.Demo
Screen.Recording.2025-01-05.at.4.44.15.PM.mov