Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made load tasks from csv files feature #91 #127

Merged
merged 10 commits into from
Jan 18, 2025

Conversation

Sanat-Jha
Copy link
Collaborator

Related Issue

Closes #91

Type of Change

Put x inside the square bracket to specify what type of change your PR is:

  • New Feature

Description of Change

User can use earlier exported csv file of tasks to load new tasks in app.

Demo

image
image
image
image

title: row[0].toString(),
description: row[1].toString(),
isCompleted: row[2].toString().toLowerCase() == 'true',
hasDeadline: row[3].toString().toLowerCase() == 'true',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanat-Jha This is no longer a field inside class Task. Please update accordingly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akshit517 Updated, please review.

Copy link
Collaborator

@Akshit517 Akshit517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanat-Jha I am not able to import tasks that has no deadline

@Sanat-Jha
Copy link
Collaborator Author

@Akshit517 Bug of no deadline tasks not loading resolved. Please review

Copy link
Collaborator

@Akshit517 Akshit517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanat-Jha Don't remove dependencies. It may cause error.

@Sanat-Jha
Copy link
Collaborator Author

@Sanat-Jha Sorry it was unintentionally done by mistake while pushing the commits. I have updated the dependencies files to current main branch code. Please review.

Copy link
Collaborator

@Akshit517 Akshit517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanat-Jha also don't remove permissions. it may be required by other dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved this too, added the permissions that were removed by error.

@Sanat-Jha
Copy link
Collaborator Author

@Akshit517 issue resolved please review

@Akshit517 Akshit517 merged commit e7efacb into IMGIITRoorkee:main Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]Import tasks from backup csv
2 participants