Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading message when we are fetching tickets on home page #76

Closed
disvid opened this issue Dec 28, 2024 · 3 comments · Fixed by #93
Closed

Add loading message when we are fetching tickets on home page #76

disvid opened this issue Dec 28, 2024 · 3 comments · Fixed by #93
Assignees
@disvid
Labels
bug Something isn't working medium UI/UX

Comments

@disvid
Copy link
Collaborator

disvid commented Dec 28, 2024

When the home page is loading it currently shows that no tickets are found. Which can be misinterpreted by users.

Hence, add a spinning loading circle which instructs the users to wait for the tickets to be loaded.
image

Video of current experience -
Screencast from 2024-12-28 14-02-19.webm
@AyushDharDubey AyushDharDubey added bug Something isn't working medium UI/UX labels Dec 30, 2024
@disvid
Copy link
Collaborator Author

disvid commented Jan 2, 2025

@AyushDharDubey , to solve this issue we can add a new state (loading state - isLoading) and manage it with React's useState, introducing these changes in the code this is how the website will work.

  1. tickets are not found:
    Screencast from 2025-01-03 01-04-38.webm
  2. tickets are found:
    Screencast from 2025-01-03 01-08-15.webm

Please assign me this issue.
Thankyou.

@AyushDharDubey
Copy link
Collaborator

@disvid, in addition to this you might also need to change the return object of getTickets function

go ahead and open a PR to fix this one, i'm assigning the issue to you

@disvid disvid mentioned this issue Jan 4, 2025
Merged
5 tasks
@disvid
Copy link
Collaborator Author

disvid commented Jan 5, 2025

@AyushDharDubey sir i didn't find a need to change the return object of getTickets function, could you please tell me why do you think it needs to be changed and to what ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disvid disvid

Labels
bug Something isn't working medium UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added loading feature disvid/Ticketify
2 participants
@AyushDharDubey @disvid