New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code for handling attributes and objects #1

Open

cygnetix opened this issue Dec 7, 2018 · 0 comments

Assignees

Labels

Collaborator

cygnetix commented Dec 7, 2018

This was a quick hack to get objects (used by sam-bot) working quickly:
https://github.com/IRATEAU/splunk-misp/blob/master/bin/mispsearch.py#L138

It's just a copy and paste of the attribute for loop:
https://github.com/IRATEAU/splunk-misp/blob/master/bin/mispsearch.py#L112

Someone should have a think about how to DRY this out.

cygnetix added the enhancement label

cygnetix self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment