Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] unit conversion is missing for TEMPO L2 V03 troposphric NO2 ObsError #1559

Open
HyundeokChoi-NOAA opened this issue Oct 4, 2024 · 5 comments
Assignees
Labels
bug Something is not working COMPO Atmospheric COMPOsition

Comments

@HyundeokChoi-NOAA
Copy link

Current behavior (describe the bug)

The converter doesn't convert the "tropospheric NO2 ObsError" unit from [molecules/cm2] to [mole/m2] for TEMPO level 2 version 03 product.

To Reproduce

What computer are you running on?
HERA
Steps to reproduce the behavior
Test with TEMPO level 2 version 03 product for tropospheric NO2.

Expected behavior

Additional information (optional)

            # error calculation:
            err = ncd.groups['product'].variables[err_name+'_uncertainty'][:].ravel()
            if self.v3:
                if self.columnType == "total" or self.columnType == "stratosphere":
                    sys.exit("no error with total and strato NRT product")
            else:
                err = err * conv * col_amf / tot_amf
@HyundeokChoi-NOAA HyundeokChoi-NOAA added the bug Something is not working label Oct 4, 2024
@HyundeokChoi-NOAA HyundeokChoi-NOAA self-assigned this Oct 4, 2024
@mer-a-o mer-a-o added the COMPO Atmospheric COMPOsition label Oct 4, 2024
@HyundeokChoi-NOAA
Copy link
Author

Revised as below

            # error calculation:
            err = ncd.groups['product'].variables[err_name+'_uncertainty'][:].ravel()
            if self.v3:
                if self.columnType == "total" or self.columnType == "stratosphere":
                    sys.exit("no error with total and strato NRT product")
                else:
                   err = err * conv * col_amf / tot_amf
            else:
                err = err * conv * col_amf / tot_amf

@jeromebarre
Copy link
Contributor

I remember correcting this before the TEMPO meeting. I think I forgot to PR my branch. Let me do this ASAP.

@jeromebarre jeromebarre self-assigned this Oct 10, 2024
@HyundeokChoi-NOAA
Copy link
Author

I saw you revised the "cld_fra", too. It was too strict.
Thank you!!

@jeromebarre
Copy link
Contributor

No problems. For the cloud fraction 0.5 might then be a bit too loose. There is no real consensus as far as I can tell on the correct value. It really depends on your DA results after all. I suggest using something loose to remove the pixels that we know for sure will be bad at first and then use a QC filter to adjust during the DA.

@HyundeokChoi-NOAA
Copy link
Author

I agree. Also, I would like to add "solar_zeneth_angle" to the MetaData which is recommended by TEMPO science team (< 70) so that we can use it as a filter during the DA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working COMPO Atmospheric COMPOsition
Projects
None yet
Development

No branches or pull requests

3 participants